Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix bugs in reserve constraint #645

Merged
merged 4 commits into from
Apr 21, 2023
Merged

fix bugs in reserve constraint #645

merged 4 commits into from
Apr 21, 2023

Conversation

lisazeyen
Copy link
Contributor

@lisazeyen lisazeyen commented Apr 20, 2023 •
edited
Loading

Closes # (if applicable).

Fix bugs in reserve constraint

This PR should fix to bugs in the operational reserve constraint.

  1. bug: when formulating the lhs of the constraint it is summed over the time steps not the generators
  2. bug: for the additional constraint that reserve + dispatch < capacity the sign is the wrong way around

This PR does not fix the issue that this constraint only works for the power sector.

Checklist

  • I tested my contribution locally and it seems to work fine.
  • Code and workflow changes are sufficiently documented.
  • Changed dependencies are added to envs/environment.yaml.
  • Changes in configuration options are added in all of config.default.yaml.
  • Changes in configuration options are also documented in doc/configtables/*.csv.
  • A release note doc/release_notes.rst is added.

FabianHofmann
FabianHofmann requested changes Apr 20, 2023
View reviewed changes
Copy link
Contributor

@FabianHofmann FabianHofmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! I would just suggest renaming the constraint.

scripts/solve_network.py Outdated Show resolved Hide resolved
@lisazeyen @FabianHofmann
rename constraint
1cd658c 
rename constraint to fit to other syntax

Co-authored-by: Fabian Hofmann <fab.hof@gmx.de>
@fneum fneum disabled auto-merge April 21, 2023 08:06
@fneum fneum merged commit 2baacfa into master Apr 21, 2023
@fneum fneum deleted the fix-reserve-constraint branch April 21, 2023 08:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FabianHofmann FabianHofmann FabianHofmann approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@lisazeyen @FabianHofmann @fneum